bigbluebutton /
greenlight
| Conditions | 5 |
| Paths | 4 |
| Total Lines | 85 |
| Code Lines | 46 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | // BigBlueButton open source conferencing system - http://www.bigbluebutton.org/. |
||
| 17 | $(document).on('turbolinks:load', function(){ |
||
| 18 | var controller = $("body").data('controller'); |
||
| 19 | var action = $("body").data('action'); |
||
| 20 | |||
| 21 | // Only run on the admins page. |
||
| 22 | if (controller == "admins" && action == "index") { |
||
| 23 | // show the modal with the correct form action url |
||
| 24 | $(".delete-user").click(function(data){ |
||
| 25 | var uid = $(data.target).closest("tr").data("user-uid") |
||
| 26 | var url = $("body").data("relative-root") |
||
| 27 | if (!url.endsWith("/")) { |
||
| 28 | url += "/" |
||
| 29 | } |
||
| 30 | url += "u/" + uid |
||
| 31 | $("#delete-confirm").parent().attr("action", url) |
||
| 32 | }) |
||
| 33 | |||
| 34 | $('.colorinput').ColorPicker({ |
||
| 35 | onHide: function (colpkr) { |
||
|
|
|||
| 36 | var colour = $("#user-colour").val(); |
||
| 37 | |||
| 38 | // Update the color in the database and reload the page |
||
| 39 | $.post($("#coloring-path").val(), {color: colour}).done(function(data) { |
||
| 40 | location.reload() |
||
| 41 | }); |
||
| 42 | }, |
||
| 43 | |||
| 44 | onSubmit: function(hsb, hex, rgb, el) { |
||
| 45 | $.post($("#coloring-path").val(), {color: '#' + hex}).done(function(data) { |
||
| 46 | location.reload() |
||
| 47 | }); |
||
| 48 | }, |
||
| 49 | |||
| 50 | onBeforeShow: function () { |
||
| 51 | var colour = $("#user-colour").val(); |
||
| 52 | |||
| 53 | $(this).ColorPickerSetColor(colour); |
||
| 54 | }, |
||
| 55 | |||
| 56 | onChange: function (hsb, hex, rgb) { |
||
| 57 | $('.colorinput span').css('backgroundColor', '#' + hex); |
||
| 58 | $("#user-colour").val('#' + hex); |
||
| 59 | } |
||
| 60 | }); |
||
| 61 | |||
| 62 | // Submit search if the user hits enter |
||
| 63 | $("#search-input").keypress(function(key) { |
||
| 64 | var keyPressed = key.which |
||
| 65 | if (keyPressed == 13) { |
||
| 66 | searchPage() |
||
| 67 | } |
||
| 68 | }) |
||
| 69 | |||
| 70 | // Add listeners for sort |
||
| 71 | $("th[data-order]").click(function(data){ |
||
| 72 | var header_elem = $(data.target) |
||
| 73 | |||
| 74 | if(header_elem.data('order') === 'asc'){ // asc |
||
| 75 | header_elem.data('order', 'desc'); |
||
| 76 | } |
||
| 77 | else if(header_elem.data('order') === 'desc'){ // desc |
||
| 78 | header_elem.data('order', 'none'); |
||
| 79 | } |
||
| 80 | else{ // none |
||
| 81 | header_elem.data('order', 'asc'); |
||
| 82 | } |
||
| 83 | |||
| 84 | var search = $("#search-input").val() |
||
| 85 | window.location.replace(window.location.pathname + "?page=1&search=" + search + "&column=" + header_elem.data("header") + "&direction="+ header_elem.data('order')) |
||
| 86 | }) |
||
| 87 | } |
||
| 88 | |||
| 89 | // Only run on the admins edit user page. |
||
| 90 | if (controller == "admins" && action == "edit_user") { |
||
| 91 | $(".setting-btn").click(function(data){ |
||
| 92 | var url = $("body").data("relative-root") |
||
| 93 | if (!url.endsWith("/")) { |
||
| 94 | url += "/" |
||
| 95 | } |
||
| 96 | |||
| 97 | url += "admins?setting=" + data.target.id |
||
| 98 | window.location.href = url |
||
| 99 | }) |
||
| 100 | } |
||
| 101 | }); |
||
| 102 | |||
| 120 |
Loading history...
This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function.